Jackie-Jiang commented on a change in pull request #5483: URL: https://github.com/apache/incubator-pinot/pull/5483#discussion_r438974956
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/request/context/QueryContext.java ########## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.request.context; + +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.request.BrokerRequest; + + +/** + * The {@code QueryContext} class encapsulates all the query related information extracted from the wiring Object. Review comment: Yes and no. We always use `BrokerRequest` as the wire object right now, and it has the `PinotQuery` inside for SQL queries. We only need one converter from BrokerRequest to QueryRequest, but when PinotQuery exists, it will try to convert from PinotQuery. When we switch the wire object, all we need to do is add a new converter without any change on the query engine ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
