mcvsubbu commented on a change in pull request #5542:
URL: https://github.com/apache/incubator-pinot/pull/5542#discussion_r439069170
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -893,20 +891,19 @@ IdealState ensureAllPartitionsConsuming(TableConfig
tableConfig, PartitionLevelS
// Create a new segment to re-consume from the previous start
offset
LLCSegmentName newLLCSegmentName =
getNextLLCSegmentName(latestLLCSegmentName, currentTimeMs);
- long startOffset = latestSegmentZKMetadata.getStartOffset();
+ StreamPartitionMsgOffset startOffset =
offsetFactory.create(latestSegmentZKMetadata.getStartOffset());
Review comment:
A bit late for this (you had your chance in PR#5360 :), it is already in
the segment completion protocol, and also in config. I can probably change the
class name without damaging compat (I think). I would let this be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
