siddharthteotia commented on a change in pull request #5538:
URL: https://github.com/apache/incubator-pinot/pull/5538#discussion_r440490826
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -205,8 +205,9 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
metadata.put(DataTable.NUM_SEGMENTS_MATCHED, "0");
} else {
TimerContext.Timer planBuildTimer =
timerContext.startNewPhaseTimer(ServerQueryPhase.BUILD_QUERY_PLAN);
- Plan globalQueryPlan =
- _planMaker.makeInterSegmentPlan(segmentDataManagers,
brokerRequest, executorService, remainingTimeMs);
+ Plan globalQueryPlan = _planMaker
+ .makeInterSegmentPlan(segmentDataManagers,
queryContext.getBrokerRequest(), executorService,
+ remainingTimeMs);
Review comment:
Is this because of step by step migration to QueryContext? We have
already converted BrokerRequest to QueryContext at this point but for code that
hasn't yet switched to QueryContext, a backward reference to broker request is
still maintained inside QueryRequest to help with components that will still
use BrokerRequest. Is this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
