snleee commented on a change in pull request #5586:
URL: https://github.com/apache/incubator-pinot/pull/5586#discussion_r441902181
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateEvaluatorProvider.java
##########
@@ -77,8 +77,8 @@ public static PredicateEvaluator
getPredicateEvaluator(Predicate predicate, Dict
throw new UnsupportedOperationException("Unsupported predicate
type: " + predicate.getType());
}
}
- } catch (NumberFormatException e) {
- // This NumberFormatException is caused by passing in a non-numeric
string as numeric number in query
+ } catch (Exception e) {
Review comment:
Do we throw exceptions other than `NumberFormatException`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
