satishbellapu commented on issue #5580:
URL:
https://github.com/apache/incubator-pinot/issues/5580#issuecomment-646942203
@daniellavoie few comments,
**Foreground or background :**
I feel Foreground option will not be much useful unless for the quick start
or someone trying the system for the first timers, because you have to close
the services and relaunch in background for long running the system, instead of
that we can support only one mode which is background and add the following
command for debugging or exploration purpose,
```
pinot start [options] //always launch the services background
pinot log [options] //ex., pinot log zookeeper
```
Should tail the zookeeper logs for debug purpose and also not required to
close the session and relaunch the for continues running, CLI will not be
restricted for development only can be used for production as well.
After rechecking @kishoreg requirements for ingest, we can add load command
to the CLI,
```
Ex.. pinot load [load.config]
load-file.config
//content
table.name : [table-name]
data-to-load : [pathc/batch_ingestion_spec.json]
```
This way the tool can be used for multipurpose and also can launch commands
one after the other without killing the CLI and that will be so helpful for
having auto launcher scripts by support teams/devOps etc.
```
Available Commands:
start
stop
log
load
```
**Passing Pinot properties to the CLI.**
I feel adding options like `--controler.port=<port> or
--cluster-name=<cluster-name>`
to the CLI will be bad design and can’t be scalable, we should restrict the
options at service level like,
```
Options:
zookeeper
broker
controller etc
```
And the options like brokers ulr, hosts or ports etc should be part of the
properties/config file, that way you can still parse by args4j annotation
properties and validate before passing to the systems, and at CLI level you
only need to validate on predefine commands and options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
