daniellavoie commented on a change in pull request #5603:
URL: https://github.com/apache/incubator-pinot/pull/5603#discussion_r443799382
##########
File path:
pinot-spi/src/test/java/org/apache/pinot/spi/filesystem/LocalPinotFSTest.java
##########
@@ -188,7 +188,7 @@ public void testFS()
localPinotFS.touch(nonExistingFile.toURI());
Assert.assertTrue(nonExistingFile.exists());
long currentTime = System.currentTimeMillis();
- Assert.assertTrue(localPinotFS.lastModified(nonExistingFile.toURI()) <
currentTime);
+ Assert.assertTrue(localPinotFS.lastModified(nonExistingFile.toURI()) <=
currentTime);
Review comment:
I don't see in what `<=` is not a valid assertion. I'm not a fan of
adding sleeps in a codebase :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
