harleyjj commented on a change in pull request #5593:
URL: https://github.com/apache/incubator-pinot/pull/5593#discussion_r443869773
##########
File path: thirdeye/thirdeye-frontend/app/pods/manage/alerts/index/route.js
##########
@@ -27,213 +20,44 @@ export default Route.extend(AuthenticatedRouteMixin, {
model() {
return hash({
- applications: fetch('/thirdeye/entity/APPLICATION').then(checkStatus),
- detectionAlertConfig:
fetch('/detection/subscription-groups').then(checkStatus),
- polishedDetectionYaml: fetch('/yaml/list').then(checkStatus)
+ subscriptionGroupConfig:
fetch('/detection/subscription-groups').then(checkStatus),
Review comment:
@jihaozh This is fetched so that we can add Application to the alerts
for display in the UI. If we can add Application as a field in the response
from /alerts endpoint, I can get rid of this. To see what I'm talking about,
check enrichAlertResponseObject() function in yaml-tools.js
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
