Jackie-Jiang opened a new pull request #5613: URL: https://github.com/apache/incubator-pinot/pull/5613
## Description Replace `BrokerRequest` classes (`AggregationInfo`, `TransformExpressionTree`) with QueryContext classes (`FunctionContext`, `ExpressionContext`) for aggregation and transform functions This is the last PR of removing `BrokerRequest` classes from the query execution path. After this PR, the query engine will be independent of `BrokerRequest` and only access `QueryContext` classes, and all the redundant expression parsing will be saved. Besides replacing `BrokerRequest` classes, also refactored `DistinctCountThetaSketchAggregationFunction` to use the `QueryContext` classes, which solves the TODO of standardizing the predicate strings and simplifies the predicate handling. Minor bug-fixes: - Fix HLL log2m override for SQL query and make it case insensitive (In `BaseBrokerRequestHandler`) - Add special argument handling for `DistinctCountRawThetaSketch` (In `BrokerRequestToQueryContextConverter`) - Always use single argument `*` for `COUNT` when converting `FunctionCallAstNode ` to `FunctionContext` (In `QueryContextConverterUtils`) ## Upgrade Notes Because of the standardization of the `DistinctCountThetaSketch` predicate strings, please upgrade Broker before Server. The new Broker can handle both standard and non-standard predicate strings for backward-compatibility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
