vincentchenjl commented on a change in pull request #5606:
URL: https://github.com/apache/incubator-pinot/pull/5606#discussion_r445234181
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/rootcause/impl/RCAFrameworkRunner.java
##########
@@ -124,23 +115,6 @@ public static void main(String[] args) throws Exception {
System.exit(1);
}
- // runtime logger config
- setLogger(Logger.ROOT_LOGGER_NAME, Level.INFO);
-
- if (cmd.hasOption(CLI_LOG))
- setLogger(Logger.ROOT_LOGGER_NAME,
Level.valueOf(cmd.getOptionValue(CLI_LOG)));
- if (cmd.hasOption(CLI_LOG_DEBUG))
- setLogger(cmd.getOptionValue(CLI_LOG_DEBUG), Level.DEBUG);
- if (cmd.hasOption(CLI_LOG_INFO))
- setLogger(cmd.getOptionValue(CLI_LOG_INFO), Level.INFO);
- if (cmd.hasOption(CLI_LOG_WARN))
- setLogger(cmd.getOptionValue(CLI_LOG_WARN), Level.WARN);
- if (cmd.hasOption(CLI_LOG_ERROR))
- setLogger(cmd.getOptionValue(CLI_LOG_ERROR), Level.ERROR);
-
- if(cmd.hasOption(CLI_VERBOSE))
Review comment:
We are using `slf4j` for logger across the codebase and there is no way
to set the log level in runtime with `slf4j`. Also, this class is standalone
and actually never uses any logger inside. If we want to set the log level, we
can always specify log4j2 config when run this class, which is common practice
for log4j2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
