siddharthteotia commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-pinot/pull/5628#discussion_r446411312
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1796,16 +1796,16 @@ private boolean updateExistedSegment(String
tableNameWithType, String segmentNam
}
// Set all partitions to online so that they load the new segment data
- do {
- final IdealState idealState =
_helixAdmin.getResourceIdealState(_helixClusterName, tableNameWithType);
+ HelixHelper.updateIdealState(_helixZkManager, tableNameWithType,
idealState -> {
Review comment:
At least the TableRebalancer code follows this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
