mayankshriv edited a comment on pull request #5608: URL: https://github.com/apache/incubator-pinot/pull/5608#issuecomment-650796559
> I guessed that but wanted to see if there is anything beyond that. I like it. > > @mayank @sidd any thoughts? Yes, this will require changes to LinkedIn wrappers that instantiate the Pinot components via configurations. @daniellavoie Will this be feature compatible with Apache commons configuration? For example, getting configuration object for `pinot.server`. will return another configuration object with all propoerties under `pinot.server`. If not. that would be a much bigger cause for concern. Another concern is validation for this change. I don't believe there are tests in place to cover all possible usage of existing configurations. @siddharthteotia would you be able to help assess the impact on LinkedIn side? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
