snleee commented on a change in pull request #5587:
URL: https://github.com/apache/incubator-pinot/pull/5587#discussion_r447343900
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/minion/rollup/MergeRollupSegmentConverter.java
##########
@@ -49,18 +46,17 @@
private String _tableName;
private String _segmentName;
private MergeType _mergeType;
- private Map<String, String> _rolllupPreAggregateType;
+ private Map<String, String> _rollupPreAggregateType;
- private MergeRollupSegmentConverter(@Nonnull List<File> inputIndexDirs,
@Nonnull File workingDir,
- @Nonnull String tableName, @Nonnull String segmentName, @Nonnull String
mergeType,
- @Nullable Map<String, String> rollupPreAggregateType, TableConfig
tableConfig) {
+ private MergeRollupSegmentConverter(List<File> inputIndexDirs, File
workingDir, String tableName, String segmentName,
Review comment:
`rollupPreggregateType` is the mapping for the rollup. `column ->
aggregation function`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
