sajjad-moradi commented on pull request #5617: URL: https://github.com/apache/incubator-pinot/pull/5617#issuecomment-651453842
> > I would recommend putting this under the `SegmentsValidationAndRetentionConfig` instead of creating another top-level config. > > can we rename 'SegmentsValidationAndRetentionConfig' to segmentConfig? I tried to do that, but it added a lot of noise to the PR, so I decided to leave the renaming to another PR. I'll create a separate PR for it after this one goes in. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
