sajjad-moradi commented on a change in pull request #5617:
URL: https://github.com/apache/incubator-pinot/pull/5617#discussion_r449276912



##########
File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##########
@@ -177,13 +179,13 @@ public Response downloadSegment(
   private SuccessResponse uploadSegment(@Nullable String tableName, 
FormDataMultiPart multiPart,
       boolean enableParallelPushProtection, HttpHeaders headers, Request 
request, boolean moveSegmentToFinalLocation) {
     String uploadTypeStr = null;
-    String crypterClassName = null;
+    String crypterClassNameInHeader = null;

Review comment:
       If you're talking about the difference between fully qualified name vs 
just the name of the crypter, then how can we differentiate two crypters which 
have the same name but different packages?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to