Jackie-Jiang commented on a change in pull request #5624:
URL: https://github.com/apache/incubator-pinot/pull/5624#discussion_r451241624
##########
File path: pom.xml
##########
@@ -1553,8 +1553,11 @@
<exclude>**/*.properties</exclude>
<!-- IDE files -->
- <exclude>**/*.iml</exclude>
-
+ <exclude>**/*.iml</exclude>
+ <!-- Eclipse IDE files -->
+ <exclude>**/*.project</exclude>
+ <exclude>**/*.classpath</exclude>
+ <exclude>**/*.prefs</exclude>
<!-- Top level -->
Review comment:
(nit) add an empty line for readability
##########
File path: pom.xml
##########
@@ -1553,8 +1553,11 @@
<exclude>**/*.properties</exclude>
<!-- IDE files -->
- <exclude>**/*.iml</exclude>
-
+ <exclude>**/*.iml</exclude>
Review comment:
The indentation doesn't seem right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
