fx19880617 commented on a change in pull request #5707:
URL: https://github.com/apache/incubator-pinot/pull/5707#discussion_r455291608
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -438,6 +439,46 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
return brokerResponse;
}
+ /**
+ * Check if table is in the format of [database_name].[table_name].
+ *
+ * Only update TableName in QuerySource if there is no existing table in the
format of [database_name].[table_name],
+ * but only [table_name].
+ *
+ * @param brokerRequest
+ */
+ private void updateQuerySource(BrokerRequest brokerRequest) {
Review comment:
Also I feel that we should introduce the concept that no dot is allowed
in table name/column name.
I'm not sure if anyone is using dot in table name, but it's definitely some
users are using dot in column name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
