jackjlli commented on pull request #5724: URL: https://github.com/apache/incubator-pinot/pull/5724#issuecomment-662164187
> Mostly minor comments. > Two things: > > 1. Should we consider accepting a broker tag name in the API to toggle rate limiting for all brokers in the tag? (as a general functionality, not specific to LinkedIn use case) > 2. Add a metric (guage) when the config is disabled, so that if it remains disabled for a long time, we can add an alert on it For 1, I can't think of a scenario for that. But we can always add that later if necessary. For 2, just added a broker gauge called `QUERY_RATE_LIMIT_DISABLED`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
