chenboat commented on a change in pull request #5700:
URL: https://github.com/apache/incubator-pinot/pull/5700#discussion_r459630215
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SplitSegmentCommitter.java
##########
@@ -70,4 +68,15 @@ public SplitSegmentCommitter(Logger segmentLogger,
ServerSegmentCompletionProtoc
}
return commitEndResponse;
}
+
+ // Return false iff the segment upload fails.
+ protected boolean uploadSegment(File segmentTarFile, SegmentUploader
segmentUploader,
+ SegmentCompletionProtocol.Request.Params params) {
+ URI segmentLocation = segmentUploader.uploadSegment(segmentTarFile, new
LLCSegmentName(params.getSegmentName()));
+ if (segmentLocation != null) {
+ params.withSegmentLocation(segmentLocation.toString());
Review comment:
done together with change with the method return type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
