mcvsubbu commented on a change in pull request #5737:
URL: https://github.com/apache/incubator-pinot/pull/5737#discussion_r460333583
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
##########
@@ -177,25 +211,26 @@ public boolean execute()
// Completed: Use multiple (completedSize,numHours) data points to
calculate completed size for our numHours
File sampleCompletedSegmentFile = new File(_sampleCompletedSegmentDir);
- long sampleSegmentConsumedSeconds =
-
TimeUnit.SECONDS.convert(TimeUtils.convertPeriodToMillis(_periodSampleSegmentConsumed),
TimeUnit.MILLISECONDS);
-
long maxUsableHostMemBytes = DataSizeUtils.toBytes(_maxUsableHostMemory);
MemoryEstimator memoryEstimator =
- new MemoryEstimator(tableConfig, sampleCompletedSegmentFile,
sampleSegmentConsumedSeconds,
- maxUsableHostMemBytes);
+ new MemoryEstimator(tableConfig, sampleCompletedSegmentFile,
_ingestionRate, maxUsableHostMemBytes, tableRetentionHours);
File sampleStatsHistory = memoryEstimator.initializeStatsHistory();
memoryEstimator
.estimateMemoryUsed(sampleStatsHistory, numHosts, numHours,
totalConsumingPartitions, _retentionHours);
+ note.append("\n* See
https://docs.pinot.apache.org/operators/operating-pinot/tuning/realtime";);
// TODO: Make a recommendation of what config to choose by considering
more inputs such as qps
- LOGGER.info("\nMemory used per host");
- displayResults(memoryEstimator.getTotalMemoryPerHost(), numHosts,
numHours);
+
System.out.println("\n============================================================\n"
+ toString());
Review comment:
No, it will be same as the existing display() methods. So, sout it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
