fx19880617 commented on a change in pull request #5786:
URL: https://github.com/apache/incubator-pinot/pull/5786#discussion_r464200809
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java
##########
@@ -28,6 +28,7 @@
MINMAXRANGE("minMaxRange"),
DISTINCTCOUNT("distinctCount"),
DISTINCTCOUNTBITMAP("distinctCountBitmap"),
+ PARTITIONEDDISTINCTCOUNT("partitionedDistinctCount"),
Review comment:
Shall we change the function name to something like
`SEGMENTEDDISTINCTCOUT` or let `PARTITIONEDDISTINCTCOUNT` to take a parameter
of MergeLevel to indicate `segment level` or `instance level` merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
