Jackie-Jiang commented on a change in pull request #5795:
URL: https://github.com/apache/incubator-pinot/pull/5795#discussion_r464692098
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java
##########
@@ -79,7 +79,7 @@ public boolean isOfType(AggregationFunctionType...
aggregationFunctionTypes) {
* Returns the corresponding aggregation function type for the given
function name.
*/
public static AggregationFunctionType getAggregationFunctionType(String
functionName) {
- String upperCaseFunctionName = functionName.toUpperCase();
+ String upperCaseFunctionName = functionName.toUpperCase().replace("_", "");
Review comment:
This will break `ST_Union`. Can we first look up with original function
name, and if not found, replace `_` then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
