lgo opened a new issue #5801:
URL: https://github.com/apache/incubator-pinot/issues/5801


   Configuing nodes is faily confusing! For example, brokers and servers 
require `-zkAddress` parameters, whether or not they are provided a 
`-configFileName`. Meanwhile, controllers do not allow that parameter if a 
`-configFileName` is provided and instead has `controller.zk.str` configuration 
value. Same for the the `-clusterName` and `controller.helix.cluster.name` 
configuration value.
   
   This difference makes orchestration confusing.
   
   Also, as a user the `zk.str` configuration name is pretty meaninless and 
doesn't help with understanding.
   
   I imagine comitting to a consistent pattern among the launcher script 
commands would help: require `-zkAddress` on all types. Additinally, I imagine 
having a clear config value that is consistent for all of them, eg 
`zookeeper.address` (making the config agnostic of `controller` vs. `broker` 
vs. `server`)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to