jihaozh commented on a change in pull request #5778: URL: https://github.com/apache/incubator-pinot/pull/5778#discussion_r465261202
########## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/anomalies/AnomalySearchResource.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + * + */ + +package org.apache.pinot.thirdeye.dashboard.resources.v2.anomalies; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import java.util.List; +import javax.ws.rs.DefaultValue; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import org.apache.pinot.thirdeye.api.Constants; + + +/** + * The type Anomaly search resource. + */ +@Path(value = "/anomaly-search") Review comment: I'd prefer to keep them separate and eventually we will want to deprecate the old file. Reasons: - the input for the endpoints is quite different, the new one needs to support filter by multiple datasets, metrics, while the old one can only handle a single filter in each field. - the response formatting for this one is quite different. In the new one, it needs to add the pagination information, the anomaly result is on another level in the blob. Therefore just updating the old one is not going to be backward compatible. Also, in the old one, in the case of multiple filters, the filters are applied in memory instead of pushing to the database, so it's not efficient when handling a large number of anomalies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
