lgo commented on issue #5814:
URL: 
https://github.com/apache/incubator-pinot/issues/5814#issuecomment-669660367


   That still leaves the broker and server `/api` incorrectly using `http` and 
making the Swagger UI not usable.
   
   This is mostly a bug with the swagger client's selection of a scheme, which 
was fixed the PR linked above. Pinot's behind on the Swaggere UI version, but 
with the fix in Pinot can just specify `schemes: ['http', 'https']` without the 
need for any configuration value.
   
   The swagger UI version in Pinot is `2.2.2`: 
https://github.com/apache/incubator-pinot/blob/c2c623aec69b5288c365c843976d464df8c9e480/pom.xml#L898-L899
   
   Which uses `swagger-client` `2.1.18`: 
https://github.com/swagger-api/swagger-ui/blob/v2.2.2/package.json#L62
   
   The fix is only in the `swagger-client `2.1.22` 
(https://github.com/linxiaowu66/swagger-js/commit/e35ca11675f9a6121773ca99220e1dc4927bfcc2).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to