fx19880617 commented on a change in pull request #5787: URL: https://github.com/apache/incubator-pinot/pull/5787#discussion_r467512585
########## File path: pinot-connectors/pinot-spark-connector/src/main/scala/org/apache/pinot/connector/spark/connector/query/SQLSelectionQueryGenerator.scala ########## @@ -0,0 +1,101 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.connector.spark.connector.query + +import org.apache.pinot.connector.spark.connector.Constants.{PinotTableType, PinotTableTypes} +import org.apache.pinot.connector.spark.connector.{PinotUtils, TimeBoundaryInfo} + +/** + * Generate realtime and offline SQL queries for specified table with given columns and filters. + */ +private[pinot] class SQLSelectionQueryGenerator( + tableNameWithType: String, + timeBoundaryInfo: Option[TimeBoundaryInfo], + columns: Array[String], + whereClause: Option[String]) { + private val columnsExpression = columnsAsExpression() + private val rawTableName = PinotUtils.getRawTableName(tableNameWithType) + private val tableType = PinotUtils.getTableType(tableNameWithType) + + def generatePQLs(): GeneratedSQLs = { + val offlineSelectQuery = buildSelectQuery(PinotTableTypes.OFFLINE) + val realtimeSelectQuery = buildSelectQuery(PinotTableTypes.REALTIME) + GeneratedSQLs( + rawTableName, + tableType, + offlineSelectQuery, + realtimeSelectQuery + ) + } + + /** + * Get all columns if selecting columns empty(eg: resultDataFrame.count()) + */ + private def columnsAsExpression(): String = { + if (columns.isEmpty) "*" else columns.mkString(",") + } + + /** + * Build realtime or offline PQL selection query. + */ + private def buildSelectQuery(tableType: PinotTableType): String = { + val tableNameWithType = s"${rawTableName}_$tableType" + val queryBuilder = new StringBuilder(s"SELECT $columnsExpression FROM $tableNameWithType") + + // add where clause if exists + whereClause.foreach { x => + queryBuilder.append(s" WHERE $x") + } + + // add time boundary filter if exists + timeBoundaryInfo.foreach { tbi => + val timeBoundaryFilter = + if (tableType == PinotTableTypes.OFFLINE) { + tbi.getOfflinePredicate + } else { + tbi.getRealtimePredicate + } + + if (whereClause.isEmpty) { + queryBuilder.append(s" WHERE $timeBoundaryFilter") + } else { + queryBuilder.append(s" AND $timeBoundaryFilter") + } + } + + // query will be converted to Pinot 'BrokerRequest' with PQL compiler + // pinot set limit to 10 automatically + // to prevent this add limit to query + queryBuilder.append(s" LIMIT ${Int.MaxValue}") Review comment: Got it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
