npawar commented on pull request #5438: URL: https://github.com/apache/incubator-pinot/pull/5438#issuecomment-673033710
> @reallocf Can we keep java function names in camelCase and use @ScalarFunction annotation's name parameter to provide names to be used in queries? > Otherwise LGTM! Some tests are failing though. Please take a look at them. Fixed both ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
