apucher commented on a change in pull request #5961: URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482256834
########## File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml ########## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v1 +kind: ConfigMap +metadata: + name: thirdeye-pinot-quickstart-datasource-config +data: + persistence.yml: |- + databaseConfiguration: + url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye + user: {{ .Values.mysql.mysqlUser }} + password: {{ .Values.mysql.mysqlPassword }} + driver: com.mysql.jdbc.Driver + dashboard.yml: |- + authConfig: + authEnabled: false + authKey: "" + ldapUrl: "" + domainSuffix: [] + cacheTTL: 3600 + cookieTTL: 604800 + resourceConfig: [] + rootCause: + definitionsPath: rca.yml + parallelism: 5 + formatters: + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter + dashboardHost: "http://localhost:1426"; + failureFromAddress: thirdeye@localhost + failureToAddress: user@localhost + alerterConfiguration: + smtpConfiguration: + smtpHost: localhost + smtpPort: 25 + logging: + level: INFO + loggers: + org.apache.pinot: INFO + + server: + type: default + applicationConnectors: + - type: http + port: 1426 + adminConnectors: + - type: http + port: 1427 + requestLog: + type: external + whitelistDatasets: [] + swagger: + resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml" + + detector.yml: |- + logging: + level: INFO + loggers: + org.hibernate.engine.internal: WARN + server: + type: default + rootPath: '/api/*' + applicationContextPath: / + adminContextPath: /admin + applicationConnectors: + - type: http + port: 1867 + adminConnectors: + - type: http + port: 1868 + alert: false + autoload: true + # autoOnboardConfiguration: + # runFrequency: 10s + + classifier: false Review comment: We'll need separate "detector.yml" files for the **scheduler backend** and regular **worker backends**. Scheduler can be a worker too, but there can only be one scheduler active at a time. **Scheduler** alert: true autoload: true classifier: true holidayEventsLoader: true monitor: true scheduler: true worker: true/false detectionPipeline: true detectionAlert: true **Worker** alert: false autoload: false classifier: false holidayEventsLoader: false monitor: false scheduler: false worker: true detectionPipeline: false detectionAlert: false ########## File path: kubernetes/helm/thirdeye/templates/frontend/service.yaml ########## @@ -0,0 +1,38 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v1 +kind: Service +metadata: + name: {{ include "thirdeye.frontend.fullname" . }} + labels: + app: {{ include "thirdeye.name" . }} + chart: {{ include "thirdeye.chart" . }} + component: {{ .Values.frontend.name }} + release: {{ .Release.Name }} + heritage: {{ .Release.Service }} +spec: + type: LoadBalancer Review comment: should be configurable ########## File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml ########## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v1 +kind: ConfigMap +metadata: + name: thirdeye-pinot-quickstart-datasource-config +data: + persistence.yml: |- + databaseConfiguration: + url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye + user: {{ .Values.mysql.mysqlUser }} + password: {{ .Values.mysql.mysqlPassword }} + driver: com.mysql.jdbc.Driver + dashboard.yml: |- + authConfig: + authEnabled: false + authKey: "" + ldapUrl: "" + domainSuffix: [] + cacheTTL: 3600 + cookieTTL: 604800 + resourceConfig: [] + rootCause: + definitionsPath: rca.yml + parallelism: 5 + formatters: + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter + - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter + dashboardHost: "http://localhost:1426"; + failureFromAddress: thirdeye@localhost + failureToAddress: user@localhost + alerterConfiguration: + smtpConfiguration: + smtpHost: localhost + smtpPort: 25 + logging: + level: INFO + loggers: + org.apache.pinot: INFO + + server: + type: default + applicationConnectors: + - type: http + port: 1426 + adminConnectors: + - type: http + port: 1427 + requestLog: + type: external + whitelistDatasets: [] + swagger: + resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml" + + detector.yml: |- + logging: + level: INFO + loggers: + org.hibernate.engine.internal: WARN + server: + type: default + rootPath: '/api/*' + applicationContextPath: / + adminContextPath: /admin + applicationConnectors: + - type: http + port: 1867 + adminConnectors: + - type: http + port: 1868 + alert: false + autoload: true + # autoOnboardConfiguration: + # runFrequency: 10s + + classifier: false Review comment: also, worker CAN omit holidayLoaderConfiguration and SHOULD omit mockEventsLoaderconfiguration ########## File path: kubernetes/helm/thirdeye/values.yaml ########## @@ -0,0 +1,73 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# Default values for ThirdEye Deployment + +image: + repository: apachepinot/thirdeye + tag: latest + pullPolicy: IfNotPresent + +frontend: + enabled: true + name: frontend + replicaCount: 1 + port: 1426 + adminport: 1427 + + resources: {} + nodeSelector: {} + tolerations: [] + affinity: {} + podAnnotations: {} + + +backend: + enabled: true + name: backend + replicaCount: 1 + port: 1867 + adminport: 1868 + + resources: {} + nodeSelector: {} + tolerations: [] + affinity: {} + podAnnotations: {} + +# Persistence layer configuration +mysql: + mysqlRootPassword: password Review comment: this part is pretty ugly. I wonder what's the best practice for retaining the mysql secret over redeploy without exposing this here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
