jihaozh commented on a change in pull request #5962:
URL: https://github.com/apache/incubator-pinot/pull/5962#discussion_r485111715
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
##########
@@ -167,6 +175,14 @@ public DetectionPipelineTaskRunner(DetectionConfigManager
detectionDAO, MergedAn
}
this.detectionDAO.update(config);
+ // re-notify the anomalies if any
+ for (MergedAnomalyResultDTO anomaly : result.getAnomalies()) {
+ // if an anomaly should be re-notified, update the notification lookup
table in the database
+ if (anomaly.shouldRenotify()) {
Review comment:
no. the renotify flag only applies to exist anomalies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
