jackjlli commented on a change in pull request #5984:
URL: https://github.com/apache/incubator-pinot/pull/5984#discussion_r485313915
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -586,22 +586,32 @@ public boolean isSingleValue() {
public PinotDataType getSingleValueType() {
switch (this) {
+ case BYTE:
Review comment:
And this method would be called in
https://github.com/apache/incubator-pinot/blob/2cfaed37cf581362b87a36e924cdd5744d430e03/pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/DataTypeTransformer.java#L112
If the single value type between source and dest are the same, the data type
are the same. E.g. if source is string_array and dest is string, the data type
is the same, even though we should mark the flag of `single-value multi-value
mismatch`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
