Jackie-Jiang commented on a change in pull request #6012:
URL: https://github.com/apache/incubator-pinot/pull/6012#discussion_r488393909
##########
File path:
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/src/main/java/org/apache/pinot/plugin/ingestion/batch/hadoop/HadoopSegmentGenerationJobRunner.java
##########
@@ -230,7 +230,10 @@ public void run()
if (hadoopTokenFileLocation != null) {
jobConf.set("mapreduce.job.credentials.binary",
hadoopTokenFileLocation);
}
- jobConf.setInt(JobContext.NUM_MAPS, numDataFiles);
+
+ int jobParallelism =
+ (_spec.getSegmentCreationJobParallelism() > 0) ?
_spec.getSegmentCreationJobParallelism() : numDataFiles;
Review comment:
Should we use min of configured parallelism and the `numDataFiles`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
