siddharthteotia commented on a change in pull request #6027:
URL: https://github.com/apache/incubator-pinot/pull/6027#discussion_r490610341
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -94,7 +96,8 @@ public synchronized void shutDown() {
}
@Override
- public DataTable processQuery(ServerQueryRequest queryRequest,
ExecutorService executorService) {
+ public DataTable processQuery(ServerQueryRequest queryRequest,
ExecutorService executorService,
+ @Nullable StreamObserver<Server.ServerResponse> responseObserver) {
Review comment:
I think it is possible to have a separate implementation. Gradually over
time, this might need more changes and we might find ourselves polluting this
method for streaming v/s non-streaming if branches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
