Jackie-Jiang commented on a change in pull request #6031:
URL: https://github.com/apache/incubator-pinot/pull/6031#discussion_r491193744
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -1204,13 +1207,20 @@ public
LLRealtimeSegmentDataManager(RealtimeSegmentZKMetadata segmentZKMetadata,
String partitionColumn = entry.getKey();
ColumnPartitionConfig columnPartitionConfig = entry.getValue();
String partitionFunctionName = columnPartitionConfig.getFunctionName();
+
+ // NOTE: Here we compare the number of partitions from the config and
the stream, and log a warning and emit a
+ // metric when they don't match, but use the one from the
stream. The mismatch could happen when the
+ // stream partitions are changed, but the table config has not
been updated to reflect the change. In such
+ // case, picking the number of partitions from the stream can
keep the segment properly partitioned as
Review comment:
This class in on server side, so it does not rely on the validation
manager (which runs on controller side) to detect the partitions change.
I did not change the logic for this class, but only added some notes for
readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
