[GitHub] [incubator-pinot] npawar commented on a change in pull request #6038: Adding dependency validation check on Indexing config

[GitBox]

npawar commented on a change in pull request #6038:
URL: https://github.com/apache/incubator-pinot/pull/6038#discussion_r493103312



##########
File path: 
pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java
##########
@@ -544,55 +545,43 @@ public void testValidateIndexingConfig() {
     }
 
     // Although this config makes no sense, it should pass the validation phase
-    StarTreeIndexConfig starTreeIndexConfig = new 
StarTreeIndexConfig(Arrays.asList("myCol"),
-        Arrays.asList("myCol"),
-        Arrays.asList("SUM__myCol"),
-        1);
+    StarTreeIndexConfig starTreeIndexConfig =
+        new StarTreeIndexConfig(Arrays.asList("myCol"), 
Arrays.asList("myCol"), Arrays.asList("SUM__myCol"), 1);
     tableConfig = new 
TableConfigBuilder(TableType.OFFLINE).setTableName(TABLE_NAME)
-        .setStarTreeIndexConfigs(Arrays.asList(starTreeIndexConfig))
-        .build();
+        .setStarTreeIndexConfigs(Arrays.asList(starTreeIndexConfig)).build();
     try {
       TableConfigUtils.validate(tableConfig, schema);
     } catch (Exception e) {
       Assert.fail("Should fail for valid StarTreeIndex config column name");

Review comment:
       Unrelated to this PR, but is this supposed to be "should not fail" and 
also not `//expected` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org