KKcorps commented on a change in pull request #6053:
URL: https://github.com/apache/incubator-pinot/pull/6053#discussion_r494462257
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java
##########
@@ -79,7 +79,10 @@
// Geo relationship
ST_CONTAINS("ST_Contains"),
- ST_EQUALS("ST_Equals");
+ ST_EQUALS("ST_Equals"),
+
+ //Big decimal
+ ADD_WITH_PRECISION("add_with_precision");
Review comment:
Fixed.
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/AdditionWithPrecisionTransformFunction.java
##########
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.scalar.DataTypeConversionFunctions;
+import org.apache.pinot.core.common.DataSource;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+
+
+public class AdditionWithPrecisionTransformFunction extends
BaseTransformFunction {
+
+ public static final String FUNCTION_NAME = "addWithPrecision";
+
+ private List<TransformFunction> _transformFunctions = new ArrayList<>();
+ private BigDecimal[] _sums;
+ private Integer _precision = null;
+
+ @Override
+ public String getName() {
+ return FUNCTION_NAME;
+ }
+
+ @Override
+ public void init(List<TransformFunction> arguments, Map<String, DataSource>
dataSourceMap) {
+ // Check that there are more than 1 arguments
+ if (arguments.size() < 3) {
+ throw new IllegalArgumentException("At least 3 arguments are required
for ADD transform function");
+ }
+
+ for (TransformFunction argument : arguments) {
+ if (argument instanceof LiteralTransformFunction) {
+ if (_precision != null) {
+ throw new IllegalArgumentException("Only one precision value can be
specified in ADD transform function");
+ }
+ _precision = Integer.parseInt(((LiteralTransformFunction)
argument).getLiteral());
+ } else {
+ if (!argument.getResultMetadata().isSingleValue()) {
+ throw new IllegalArgumentException("All the arguments of ADD
transform function must be single-valued");
+ }
+ _transformFunctions.add(argument);
+ }
+ }
+ }
+
+ @Override
+ public TransformResultMetadata getResultMetadata() {
+ return BYTES_SV_NO_DICTIONARY_METADATA;
+ }
+
+ @Override
+ public byte[][] transformToBytesValuesSV(ProjectionBlock projectionBlock) {
+ if (_sums == null) {
+ _sums = new BigDecimal[DocIdSetPlanNode.MAX_DOC_PER_CALL];
+ }
+
+ int length = projectionBlock.getNumDocs();
+ Arrays.fill(_sums, 0, length, new BigDecimal(0));
+ MathContext mathContext;
+ if (_precision != null) {
Review comment:
resolved.
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java
##########
@@ -30,6 +30,7 @@
MIN("min"),
MAX("max"),
SUM("sum"),
+ SUMPRECISION("sumPrecision"),
Review comment:
Yes, I was actually discussing this with @kishoreg
I can allow both.
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java
##########
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.function.scalar;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import org.apache.pinot.common.function.annotations.ScalarFunction;
+
+
+public class DataTypeConversionFunctions {
+ private DataTypeConversionFunctions() {
+
+ }
+
+ @ScalarFunction
Review comment:
* Yes, it is the 2's complement representation of underling unscaled
value
* Scale is the first 4 bytes in the byte array, the remaining bytes are of
unscaled value
* The unscaled value byte array is indeed Big-endian and they are copied as
such in the result array. There's no need to swap the bytes.
In summary, the final byte array is just unscaled value's bytes appended to
scale's bytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
