Jackie-Jiang commented on a change in pull request #6004:
URL: https://github.com/apache/incubator-pinot/pull/6004#discussion_r496922926
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java
##########
@@ -776,6 +783,69 @@ public IdSet deserialize(ByteBuffer byteBuffer) {
}
};
+ public static final ObjectSerDe<List<Object>> LIST_SER_DE = new
ObjectSerDe<List<Object>>() {
+
+ @Override
+ public byte[] serialize(List<Object> list) {
+ int size = list.size();
+
+ // Directly return the size (0) for empty list
+ if (size == 0) {
+ return new byte[Integer.BYTES];
Review comment:
It is safer to not reuse this as we have no control on not modifying it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
