danbosnichill commented on a change in pull request #6104:
URL: https://github.com/apache/incubator-pinot/pull/6104#discussion_r499323328
##########
File path:
pinot-plugins/pinot-file-system/pinot-s3/src/main/java/org/apache/pinot/plugin/filesystem/S3PinotFS.java
##########
@@ -93,7 +95,16 @@ public void init(PinotConfiguration config) {
awsCredentialsProvider = DefaultCredentialsProvider.create();
}
- _s3Client =
S3Client.builder().region(Region.of(region)).credentialsProvider(awsCredentialsProvider).build();
+ S3ClientBuilder s3ClientBuilder =
S3Client.builder().region(Region.of(region)).credentialsProvider(awsCredentialsProvider);
Review comment:
It might make sense then to make region optional. I wasn't able to test
this locally (given I can't build Pinot). I think keeping it required is a
safer diff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
