Jackie-Jiang commented on a change in pull request #6103:
URL: https://github.com/apache/incubator-pinot/pull/6103#discussion_r499783811
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -269,6 +270,7 @@ public void addSegment(String segmentName, TableConfig
tableConfig, IndexLoading
}
_logger.info("Initialize RealtimeSegmentDataManager - " + segmentName);
_segmentDataManagerMap.put(segmentName, manager);
+ _serverMetrics.addValueToTableGauge(_tableNameWithType,
ServerGauge.SEGMENT_COUNT, 1L);
Review comment:
This one should be added inside the else block in line 237, or we will
double counting because this gauge will also be updated in
`addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig, schema));`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
