mayankshriv commented on pull request #6044: URL: https://github.com/apache/incubator-pinot/pull/6044#issuecomment-708113812
> I still feel using fixed thread pool for single-threaded case can add overhead to the reducer, but if the perf shows no difference, I'm okay with it. I agree that it will add overhead. The question is how much, and is it worth complicating the code with multiple implementations (one for single and one for multi threads). Let's use this as baseline and improve if we see a degradation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
