Jackie-Jiang commented on a change in pull request #6167:
URL: https://github.com/apache/incubator-pinot/pull/6167#discussion_r509545239
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/upsert/PartitionUpsertMetadataManager.java
##########
@@ -29,97 +30,142 @@
/**
* Manages the upsert metadata per partition.
+ * <p>For multiple records with the same timestamp, there is no guarantee on
which record to be preserved.
+ * <p>There will be short term inconsistency when updating the upsert
metadata, but should be consistent after the
+ * operation is done:
+ * <ul>
+ * <li>
+ * When updating a new record, it first removes the doc id from the
current location, then update the new location.
+ * </li>
+ * <li>
+ * When adding a new segment, it removes the doc ids from the current
locations before the segment being added to
+ * the RealtimeTableDataManager.
+ * </li>
+ * <li>
+ * When replacing an existing segment, the updates applied to the new
segment won't be reflected to the replaced
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
