Jackie-Jiang commented on a change in pull request #6181:
URL: https://github.com/apache/incubator-pinot/pull/6181#discussion_r511048205
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -60,7 +60,7 @@
// Default settings
private static final String DEFAULT_PQL_QUERY_FILE_NAME =
- "On_Time_On_Time_Performance_2014_100k_subset.test_queries_10K";
+ "On_Time_On_Time_Performance_2014_100k_subset.test_queries_1K";
Review comment:
Correctly reflect the number of queries?
```suggestion
"On_Time_On_Time_Performance_2014_100k_subset.test_queries_500";
```
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
##########
@@ -320,19 +320,18 @@ public void testQueriesFromQueryFile()
assertNotNull(resourceUrl);
File queryFile = new File(resourceUrl.getFile());
- int maxNumQueriesToSkipInQueryFile = getMaxNumQueriesToSkipInQueryFile();
try (BufferedReader reader = new BufferedReader(new
FileReader(queryFile))) {
while (true) {
Review comment:
(nit)
```suggestion
String queryString;
while ((queryString = reader.readLine()) != null) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
