fx19880617 commented on a change in pull request #6186:
URL: https://github.com/apache/incubator-pinot/pull/6186#discussion_r511547073
##########
File path:
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -187,6 +174,22 @@ private static void validateGroupByClause(PinotQuery
pinotQuery)
}
}
+ private static boolean expressionOutsideGroupByList(Expression expr,
Set<Expression> groupByExprs) {
+ if (expr.getType() == ExpressionType.LITERAL ||
isAggregateExpression(expr) || groupByExprs.contains(expr)) {
Review comment:
Will this `groupByExprs.contains(expr)` handles functions or just for
identifiers?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
