jtao15 commented on a change in pull request #6224:
URL: https://github.com/apache/incubator-pinot/pull/6224#discussion_r521702422
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ClusterIntegrationTestUtils.java
##########
@@ -833,6 +700,33 @@ static void testSqlQuery(String pinotQuery, String
brokerUrl, org.apache.pinot.c
return;
}
+ BrokerRequest brokerRequest =
+
PinotQueryParserFactory.get(CommonConstants.Broker.Request.SQL).compileToBrokerRequest(pinotQuery);
+ // Add order by columns which are not in selection clause for comparison
purpose
+ List<String> orderByColumns = new ArrayList<>();
+ List<String> selectionColumns = new ArrayList<>();
+ if (isSelectionQuery(brokerRequest) && brokerRequest.getOrderBy() != null
&& brokerRequest.getOrderBy().size() > 0) {
+
orderByColumns.addAll(CalciteSqlParser.extractIdentifiers(brokerRequest.getPinotQuery().getOrderByList(),
false));
+
selectionColumns.addAll(CalciteSqlParser.extractIdentifiers(brokerRequest.getPinotQuery().getSelectList(),
false));
+ convertToUpperCase(orderByColumns);
+ convertToUpperCase(selectionColumns);
+
+ if (!selectionColumns.containsAll(orderByColumns)) {
+ List<String> inputRequests = new ArrayList<>();
+ inputRequests.add(pinotQuery);
+ inputRequests.addAll(sqlQueries);
+
+ Set<String> orderByColumnsExcluded = new HashSet<>(orderByColumns);
+ orderByColumnsExcluded.removeAll(selectionColumns);
+
+ // Append order-by columns not in selection clause so the order of
query responses can be verified
+ // e.g. we can't verify the order of query `SELECT firstName FROM
mytable ORDER BY lastName' if there are duplicate lastNames
Review comment:
I'll remove this to be consistent with pql comparison, the values are
still being checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
