mcvsubbu commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r523249976
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -984,32 +984,57 @@ private void fixColumnName(String rawTableName,
TransformExpressionTree expressi
private void fixColumnName(String rawTableName, Expression expression,
@Nullable Map<String, String> columnNameMap) {
ExpressionType expressionType = expression.getType();
if (expressionType == ExpressionType.IDENTIFIER) {
- Identifier identifier = expression.getIdentifier();
- identifier.setName(getActualColumnName(rawTableName,
identifier.getName(), columnNameMap));
+ if (!isStarIdentifier(expression)) {
Review comment:
One way we can avoid a bit of code is if we use `SqlShuttle` on the
compiled `SqlNode`, to pull out `SqlIdentifier` names, and check if they are in
schema. We will still have to exclude the target of `AS`, and in order to do
so, will need to walk the `SqlNode` and first recognize all such targets.
I can't think of other methods.
I do think that this is better resolved in the broker than in the server.
@kishoreg , @siddharthteotia any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
