Jackie-Jiang commented on a change in pull request #6094:
URL: https://github.com/apache/incubator-pinot/pull/6094#discussion_r523335905
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -148,6 +153,23 @@ public static URI
getRetrieveAllSegmentWithTableTypeHttpUri(String host, int por
rawTableName + TYPE_DELIMITER + tableType));
}
+ public static URI getStartReplaceSegmentsURI(URI controllerURI, String
rawTableName, String tableType)
+ throws URISyntaxException {
+ return new URI(StringUtil.join("/", StringUtils
Review comment:
Maybe that's the reason why `getDeleteSegmentHttpUri()` and
`getRetrieveAllSegmentWithTableTypeHttpUri()` are not using `getURI()`? We
should fix it maybe, but out of the scope of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
