dharakk commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r533171720
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java
##########
@@ -133,6 +135,10 @@ private void checkReplication(InstancePartitions
instancePartitions) {
private List<String> assignSegment(String segmentName, Map<String,
Map<String, String>> currentAssignment,
InstancePartitions instancePartitions) {
int numReplicaGroups = instancePartitions.getNumReplicaGroups();
+ if (_isDimTable) {
Review comment:
Thanks for the suggestion, this makes the code much cleaner and also
allows to add an implementation of `rebalanceTable` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
