siddharthteotia commented on a change in pull request #6285:
URL: https://github.com/apache/incubator-pinot/pull/6285#discussion_r533683065



##########
File path: 
pinot-core/src/test/java/org/apache/pinot/queries/InnerSegmentAggregationSingleValueQueriesTest.java
##########
@@ -175,26 +178,23 @@ public void testVeryLargeAggregationGroupBy() {
   @Test
   public void testSingleColumnDistinct() {

Review comment:
       Can we add another 2 similar tests for single and multi column distinct 
on dictionary encoded columns. Here both the tests are on raw columns (and so 
we use DistinctTable)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to