mcvsubbu commented on issue #6308: URL: https://github.com/apache/incubator-pinot/issues/6308#issuecomment-738148942
I disagree that ERROR state should trigger a consume stop. The ERROR state is set (perhaps not best name) when the segment build fails. We can change the name to SEGMENT_BUILD_FAILED if you like, and it is an end state. In production use case, there are always multiple replicas, and we should attempt to download if the build fails -- for whatever reason. We could check the number of replicas, and if it is one, we know that on a build failure, there will be nothing to download, and we can post the consumptionStopped message. Another way to solve this whole problem is to introduce special code to monitor the consumption-stopped metric. If it stops for more than (say) 2 mins, then kill the process (call system.exit()). This can be done in service manager code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
