richardstartin commented on pull request #6320: URL: https://github.com/apache/incubator-pinot/pull/6320#issuecomment-739429849
@Jackie-Jiang with the last commit there was another performance improvement and a reduction in allocation rate following your suggestions. I have also tried to adhere to the style guidance. before ``` Benchmark (assignment) (cardinality) (numDocs) Mode Cnt Score Error Units BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 1000000 ss 5 0.030 ± 0.003 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 10000000 ss 5 0.374 ± 0.265 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 100000000 ss 5 4.077 ± 0.191 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 1000000 ss 5 0.090 ± 0.012 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 10000000 ss 5 1.070 ± 0.304 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 100000000 ss 5 11.465 ± 0.308 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 1000000 ss 5 0.152 ± 0.040 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 10000000 ss 5 1.639 ± 0.067 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 100000000 ss 5 17.002 ± 0.217 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 1000000 ss 5 0.021 ± 0.002 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 10000000 ss 5 0.212 ± 0.004 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 100000000 ss 5 2.283 ± 0.109 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 1000000 ss 5 0.075 ± 0.002 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 10000000 ss 5 0.296 ± 0.189 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 100000000 ss 5 2.094 ± 0.284 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 1000000 ss 5 0.093 ± 0.014 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 10000000 ss 5 0.891 ± 0.327 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 100000000 ss 5 3.736 ± 0.067 s/op ``` after ``` Benchmark (assignment) (cardinality) (numDocs) Mode Cnt Score Error Units BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 1000000 ss 5 0.016 ± 0.004 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 10000000 ss 5 0.179 ± 0.021 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10 100000000 ss 5 1.711 ± 0.014 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 1000000 ss 5 0.024 ± 0.002 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 10000000 ss 5 0.233 ± 0.034 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 1000 100000000 ss 5 2.118 ± 0.007 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 1000000 ss 5 0.048 ± 0.025 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 10000000 ss 5 0.401 ± 0.090 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal ROUND_ROBIN 10000 100000000 ss 5 3.575 ± 0.007 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 1000000 ss 5 0.014 ± 0.002 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 10000000 ss 5 0.123 ± 0.004 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10 100000000 ss 5 1.444 ± 0.101 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 1000000 ss 5 0.018 ± 0.002 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 10000000 ss 5 0.147 ± 0.029 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 1000 100000000 ss 5 1.513 ± 0.082 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 1000000 ss 5 0.022 ± 0.007 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 10000000 ss 5 0.175 ± 0.022 s/op BenchmarkOffheapBitmapInvertedIndexCreator.seal SORTED_UNIFORM 10000 100000000 ss 5 1.350 ± 0.040 s/op ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
