mcvsubbu commented on a change in pull request #6344:
URL: https://github.com/apache/incubator-pinot/pull/6344#discussion_r540406760
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/stream/v2/Checkpoint.java
##########
@@ -0,0 +1,6 @@
+package org.apache.pinot.spi.stream.v2;
+
+public interface Checkpoint {
Review comment:
We agreed to rename this.
Also, we don't need stream.v2. We can add this in the existing stream
interfaces.
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/stream/v2/ConsumerV2.java
##########
@@ -0,0 +1,6 @@
+package org.apache.pinot.spi.stream.v2;
+
+public interface ConsumerV2 {
Review comment:
This is not a preferable name. Let us discuss in the design doc
##########
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/stream/v2/StreamConsumerFactoryV2.java
##########
@@ -0,0 +1,19 @@
+package org.apache.pinot.spi.stream.v2;
+
+import java.util.Map;
+import org.apache.pinot.spi.stream.StreamConfig;
+
+
+public interface StreamConsumerFactoryV2 {
Review comment:
Don't need this. We can add new methods to the existing interface with
default implemetations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
