amrishlal commented on a change in pull request #6326:
URL: https://github.com/apache/incubator-pinot/pull/6326#discussion_r542113752
##########
File path:
pinot-controller/src/test/java/org/apache/pinot/controller/api/AccessControlTest.java
##########
@@ -19,49 +19,40 @@
package org.apache.pinot.controller.api;
import java.io.IOException;
-import java.util.Map;
-
-import org.apache.pinot.controller.ControllerConf;
import org.apache.pinot.controller.api.access.AccessControl;
import org.apache.pinot.controller.api.access.AccessControlFactory;
-import org.apache.pinot.controller.helix.ControllerTest;
import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
+import static org.apache.pinot.controller.ControllerTestUtils.*;
-public class AccessControlTest extends ControllerTest {
- @BeforeClass
- public void setUp() {
- startZk();
-
- Map<String, Object> properties = getDefaultControllerConfiguration();
- properties.put(ControllerConf.ACCESS_CONTROL_FACTORY_CLASS,
DenyAllAccessFactory.class.getName());
+public class AccessControlTest {
+
+ private static final String TABLE_NAME = "accessTestTable";
- startController(properties);
+ @BeforeClass
+ public void setUp() throws Exception {
+ validate();
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
